Skip to content

Validate minimum_limit#7981

Closed
pieterbeulque wants to merge 1 commit intomainfrom
pieter/validate-minimum-interval-on-back-end
Closed

Validate minimum_limit#7981
pieterbeulque wants to merge 1 commit intomainfrom
pieter/validate-minimum-interval-on-back-end

Conversation

@pieterbeulque
Copy link
Contributor

I think this can break the analytics in the native app, as monthly is no longer a valid interval for date ranges < 60 days.

cc @sebastianekstrom

@vercel
Copy link

vercel bot commented Nov 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
polar Ignored Ignored Nov 21, 2025 10:08am
polar-sandbox Ignored Ignored Nov 21, 2025 10:08am

@frankie567
Copy link
Member

@pieterbeulque Should we merge this?

@pieterbeulque
Copy link
Contributor Author

@sebastianekstrom - Can I pass this to you? It'll need some context grabbing but basically on our analytics we now have a minimum date range too. So you can't show your metrics monthly if total date range is fewer than 60 days, for example.

How I'd go about this is first verifying how the analytics are shown & what the supported date ranges are. Do we have date picker + hourly/daily/weekly/monthly selector in the native app? That functionality should match the limitations we now have in /dashboard/[organization]/analytics. Once the native app can't send in any unsupported combinations, we can merge this.

Feel free to pull me in on Slack!

@pieterbeulque
Copy link
Contributor Author

F— it.

@pieterbeulque pieterbeulque deleted the pieter/validate-minimum-interval-on-back-end branch March 10, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants